Allow 1-2 byte strings in the dictionary #354
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Interning 1-2 byte strings isn't very useful because their binary format is longer / equal to simply encoding it as a string. So we shouldn't try to automatically intern those strings. However, if someone adds such string to their dict, they probably want it interned anyway. (In my case to reduce allocations.) After this change, people explicitly passing a dict with 1-2 byte entries will see different binary output from msgpack. Decoding keeps working. Automatic interning is unchanged.
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Interning 1-2 byte strings isn't very useful because their binary format is longer / equal to simply encoding it as a string. So we shouldn't try to automatically intern those strings.
However, if someone adds such string to their dict, they probably want it interned anyway. (In my case to reduce allocations.)
After this change, people explicitly passing a dict with 1-2 byte entries will see different binary output from msgpack. Decoding keeps working. Automatic interning is unchanged.